Enhancements protocol configuration markers by turmelclem · Pull Request #3504 · IntersectMBO/mithril

turmelclem · 2026-08-28T16:47:15Z

Content

Minor update after #3393

Fix protocol configuration markers runbook (environment variables export, jq formatting and commands results)
Add a new option to the import-markers command, --force, which bypasses the verify_configurations_against_chain function when producing the datum file
Add logs of the fetched Mithril network configuration in the signer and aggregator
Update JSON config files in mithril-aggregator/config (removing protocol_parameters, adding protocol_configuration_reader_adapter_config for preview)

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- All check jobs of the CI have succeeded
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)
- Add ADR blog post or Dev ADR entry (if relevant)
- No new TODOs introduced

This PR closes #3503

Copilot

Pull request overview

This PR improves the protocol configuration markers workflow (post-#3393) by enhancing operational documentation, adding an “emergency” CLI mode to skip a safety guard during datum generation, and increasing observability by logging fetched Mithril network configuration in both signer and aggregator components.

Changes:

Add debug logging of fetched MithrilNetworkConfiguration in the signer state machine and aggregator epoch service.
Add --force to the protocol-configuration import markers command to bypass on-chain configuration verification.
Update the protocol-configuration markers runbook and adjust aggregator JSON configs for preview/dev.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
mithril-signer/src/runtime/state_machine.rs	Adds debug logging for the fetched network configuration.
mithril-aggregator/src/services/epoch_service.rs	Adds debug logging for the fetched network configuration during epoch informing.
mithril-aggregator/src/commands/protocol_configuration_command.rs	Introduces `--force` on `import-markers` and updates default protocol parameters; updates CLI parsing test.
mithril-aggregator/config/preview.json	Removes `protocol_parameters` and adds protocol-configuration reader adapter config and other settings for preview.
mithril-aggregator/config/dev.json	Removes `protocol_parameters` and updates adapter-related configuration keys.
docs/runbook/protocol-configuration-markers/README.md	Improves runbook commands/output examples and formatting; updates env var naming.

Suppressed comments (2)

docs/runbook/protocol-configuration-markers/README.md:142

Wording: “informations” should be “information”.

Execution of previous command must return following informations :

docs/runbook/protocol-configuration-markers/README.md:153

Spelling in the added command output: “Sucessfully” should be “Successfully”.

Sucessfully wrote Tx datum file at **YOUR_ASSET_PATH**/protocol-configurations-datum.json

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-08-28T17:02:25Z

Test Results

5 files ± 0 221 suites ±0 56m 52s ⏱️ - 1h 6m 53s
3 505 tests - 57 3 505 ✅ - 57 0 💤 ±0 0 ❌ ±0
11 612 runs - 66 11 612 ✅ - 66 0 💤 ±0 0 ❌ ±0

Results for commit 2fd9a6d. ± Comparison against base commit b780e13.

This pull request removes 57 tests.

mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Suppressed comments (3)

docs/runbook/protocol-configuration-markers/README.md:142

Grammar: “informations” should be singular here (and no space before the colon).

Execution of previous command must return the following informations :

docs/runbook/protocol-configuration-markers/README.md:145

This output example uses **YOUR_ASSET_PATH**, but the runbook defines ASSETS_PATH and uses **YOUR_ASSETS_PATH** elsewhere. Use the same placeholder consistently.

Reading file content **YOUR_ASSET_PATH**/protocol-configurations.json

docs/runbook/protocol-configuration-markers/README.md:153

This output example uses **YOUR_ASSET_PATH**, but the runbook defines ASSETS_PATH and uses **YOUR_ASSETS_PATH** elsewhere. Use the same placeholder consistently.

Successfully wrote Tx datum file at **YOUR_ASSET_PATH**/protocol-configurations-datum.json

jpraynaud

LGTM 👍

…rkers datum generation and update default protocol parameters

…ration

…ntln

…atic

* mithril-aggregator from `0.10.1` to `0.10.2` * mithril-signer from `1.2.0` to `1.2.1`

turmelclem self-assigned this Aug 28, 2026

jpraynaud requested a lite review from Copilot August 28, 2026 16:48

Copilot started reviewing on behalf of jpraynaud August 28, 2026 16:48 View session

Copilot AI reviewed Aug 28, 2026

View reviewed changes

turmelclem deployed to testing-preview August 28, 2026 17:04 — with GitHub Actions Active

turmelclem deployed to testing-2-preview August 28, 2026 17:04 — with GitHub Actions Active

turmelclem force-pushed the ctl/3503-fix-runbook-and-improve-nodes-logs-and-configurations branch from 9ab8cb2 to e7a7edc Compare August 31, 2026 08:04

turmelclem deployed to testing-preview August 31, 2026 08:22 — with GitHub Actions Active

turmelclem deployed to testing-2-preview August 31, 2026 08:22 — with GitHub Actions Active

turmelclem deployed to testing-preview August 31, 2026 09:58 — with GitHub Actions Active

turmelclem deployed to testing-2-preview August 31, 2026 09:58 — with GitHub Actions Active

turmelclem force-pushed the ctl/3503-fix-runbook-and-improve-nodes-logs-and-configurations branch from edb5c4c to b90612c Compare August 31, 2026 10:06

turmelclem marked this pull request as ready for review August 31, 2026 10:07

turmelclem requested review from Alenar and jpraynaud as code owners August 31, 2026 10:07

jpraynaud requested a lite review from Copilot August 31, 2026 10:13

Copilot started reviewing on behalf of jpraynaud August 31, 2026 10:13 View session

Copilot AI reviewed Aug 31, 2026

View reviewed changes

Comment thread docs/runbook/protocol-configuration-markers/README.md Outdated

Comment thread mithril-aggregator/config/preview.json Outdated

Comment thread docs/runbook/protocol-configuration-markers/README.md Outdated

jpraynaud approved these changes Aug 31, 2026

View reviewed changes

Comment thread docs/runbook/protocol-configuration-markers/README.md Outdated

Comment thread mithril-aggregator/src/commands/protocol_configuration_command.rs Outdated

turmelclem deployed to testing-preview August 31, 2026 10:24 — with GitHub Actions Active

turmelclem deployed to testing-2-preview August 31, 2026 10:24 — with GitHub Actions Active

turmelclem added 7 commits August 31, 2026 14:30

docs: fix protocol configuration markers runbook

b284da3

refactor(aggregator): add option --force on protocol configuration ma…

112939d

…rkers datum generation and update default protocol parameters

refactor(aggregator): add a debug log showing Mithril network configu…

d686461

…ration

refactor(signer): add a debug log showing Mithril network configuration

d42a4f4

refactor(aggregator): update dev and preview config files variables

62765fe

refactor(aggregator): fix typo in protocol-configuration commands pri…

5047b84

…ntln

refactor(aggregator): make protocol-configuration tx-datum helpers st…

f8d4b38

…atic

turmelclem force-pushed the ctl/3503-fix-runbook-and-improve-nodes-logs-and-configurations branch from b90612c to f8d4b38 Compare August 31, 2026 12:30

turmelclem deployed to testing-preview August 31, 2026 12:44 — with GitHub Actions Active

turmelclem deployed to testing-2-preview August 31, 2026 12:44 — with GitHub Actions Active

Alenar approved these changes Aug 31, 2026

View reviewed changes

chore: upgrade crate versions

2fd9a6d

* mithril-aggregator from `0.10.1` to `0.10.2` * mithril-signer from `1.2.0` to `1.2.1`

turmelclem deployed to testing-2-preview August 31, 2026 15:19 — with GitHub Actions Active

turmelclem deployed to testing-preview August 31, 2026 15:19 — with GitHub Actions Active

turmelclem merged commit 69572a0 into main Aug 31, 2026
92 of 94 checks passed

turmelclem deleted the ctl/3503-fix-runbook-and-improve-nodes-logs-and-configurations branch August 31, 2026 15:29

Navigation Menu

Uh oh!

Enhancements protocol configuration markers - #3504

Enhancements protocol configuration markers#3504
turmelclem merged 8 commits into
mainfrom
ctl/3503-fix-runbook-and-improve-nodes-logs-and-configurations

turmelclem commented Aug 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

turmelclem commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

turmelclem commented Aug 28, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading